Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature request] add postgres-instance provisioner based on postgres provisioner #219

Open
astromechza opened this issue Dec 6, 2024 · 2 comments
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@astromechza
Copy link
Member

In some cases, the workload expects to receive an admin user credentials for a database host and the app will create it's own database within the instance. We usually call this an -instance resource and it has the same outputs except that it provides the root user and password and without the database/name output.

This should be based on the same shared state as the existing postgres provisioner.

@astromechza astromechza added the enhancement New feature or request label Dec 6, 2024
@mathieu-benoit
Copy link
Contributor

Good example with Backstage indeed, thanks for capturing this!

@mathieu-benoit mathieu-benoit changed the title [feature request] add postgres-instance provisioner based on postgres provisioner [feature request] add postgres-instance provisioner based on postgres provisioner Dec 6, 2024
@astromechza astromechza added the good first issue Good for newcomers label Dec 6, 2024
@mathieu-benoit
Copy link
Contributor

mathieu-benoit commented Dec 9, 2024

@astromechza, as a side note here, in the score-k8s's default provisioner, the implementation is different. I'm wondering in which direction we should go though:

  1. Like current score-k8s (i.e. allowing the postgres to create databases)?
  2. Or like recommended in this current issue by adding a new postgres-instance but them have this consistent in score-k8s for consistency?

Also, quid of mysql, mssql, etc. where we should go with this approach too for consistency?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants