Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Search functionality of stack is not working. #173

Open
2 of 3 tasks
Rupeshiya opened this issue Dec 20, 2019 · 2 comments · May be fixed by #176
Open
2 of 3 tasks

Search functionality of stack is not working. #173

Rupeshiya opened this issue Dec 20, 2019 · 2 comments · May be fixed by #176

Comments

@Rupeshiya
Copy link

Before you describe your issue, idea or feature, please consider using this issue template.

Search functionality of stack is not working.

Type of issue:

  • Bug / Error
  • Idea / Feature
  • Improvement detail

Short description on the issue

After running both the server and client-side move to http://localhost:4200/app/commonFeed
Create some stacks and after that try to search using the search bar in the sidebar and check the network tab, it's neither sending any request to the server for searching nor showing any result.

Possible fix

Make a request to the server for the search stack (if backend exists for this functionality else create API as well) and then retrieve the result and then render it.

@Rupeshiya
Copy link
Author

@psnmissaka I found that this is not implemented yet.
Can I take this up?

@Rupeshiya Rupeshiya linked a pull request Dec 25, 2019 that will close this issue
1 task
@Rupeshiya
Copy link
Author

@psnmissaka I have already implemented this functionality and now result is coming in console, so where to display these search results?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant