You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Considering that Spidermon was created at Zyte (former Scrapinghub), it is understandable that we have monitors and actions that are related to services provided by it. However, considering that Spidermon can be used by users that are not running their spiders at Zyte infrastructure, it would be a good refactoring to keep every code that is Zyte-related only inside a separated module.
My first suggestion is to move everything (actions, monitors, mixins and utils) that are spread in the project into a separated spidermon.contrib.zyte.* module, so it will be clear to everyone that anything imported from this module is related to Zyte and may require that the extension is being executed inside Zyte infrastructure.
I found Zyte-only related code in the following files:
Considering that Spidermon was created at Zyte (former Scrapinghub), it is understandable that we have monitors and actions that are related to services provided by it. However, considering that Spidermon can be used by users that are not running their spiders at Zyte infrastructure, it would be a good refactoring to keep every code that is Zyte-related only inside a separated module.
My first suggestion is to move everything (actions, monitors, mixins and utils) that are spread in the project into a separated
spidermon.contrib.zyte.*
module, so it will be clear to everyone that anything imported from this module is related to Zyte and may require that the extension is being executed inside Zyte infrastructure.I found Zyte-only related code in the following files:
Tasks to accomplish
spidermon.contrib.zyte
moduleThe text was updated successfully, but these errors were encountered: