Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Encode data uri should use the correct data header when converting an mp3 sound to a string #69

Open
kchadha opened this issue Jan 10, 2019 · 0 comments
Open

Encode data uri should use the correct data header when converting an mp3 sound to a string #69

kchadha opened this issue Jan 10, 2019 · 0 comments
Labels
bug tech debt
Milestone
Backlog

Comments

@kchadha
Copy link
Contributor

kchadha commented Jan 10, 2019

Currently, encodeDataUri uses the wave header, even for mp3 sounds. It should not. When this is fixed, there will also need to be a patch to scratch-gui/src/lib/backpack/sound-payload.js.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug tech debt
Projects
None yet
Milestone
Backlog
Development

No branches or pull requests
2 participants
@thisandagain @kchadha