Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Should SVG string fixups be exported or moved to a new module? #97

Open
adroitwhiz opened this issue Jul 15, 2019 · 1 comment · May be fixed by #210
Open

Should SVG string fixups be exported or moved to a new module? #97

adroitwhiz opened this issue Jul 15, 2019 · 1 comment · May be fixed by #210
Labels
needs-triage

Comments

@adroitwhiz
Copy link
Contributor

This is a bit of a follow-up to #96. Currently, there are SVGs which will render properly, but will crash the paint editor and/or not be displayed by the browser because they cannot be parsed.

Fixing this would require scratch-paint and scratch-gui to call the "fixup SVG string" function; however, this module does not currently export it.

Should scratch-svg-renderer export "fixup SVG string" as a public function?
@linushp
Copy link

linushp commented Jul 30, 2019

yes

@adroitwhiz adroitwhiz linked a pull request Jan 7, 2021 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
needs-triage
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Export fixupSvgString from module adroitwhiz/scratch-svg-renderer
3 participants
@ericrosenbaum @linushp @adroitwhiz