Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix annotation color shades given new backgrounds #190

Closed
2 tasks done
andrewtavis opened this issue Aug 13, 2022 · 1 comment
Closed
2 tasks done

Fix annotation color shades given new backgrounds #190

andrewtavis opened this issue Aug 13, 2022 · 1 comment
Assignees
Labels
-priority- High priority design Relates to UX/UI designs good first issue Good for newcomers help wanted Extra attention is needed

Comments

@andrewtavis
Copy link
Member

Terms

Description

Once #188 is finished, we're going to need to get new shades of the noun-gender annotation colors. These changes will happen in KeyboardsBase/ColorVariables.swift. The light mode colors will need to be made darker, and the dark mode colors will need to be made lighter (light mode annotations were over white, but are now over light grey, and dark mode annotations were over black, but are now over dark grey).

I think the best way to do this is to use the palette tool at coolors.co. If someone wants to do this, then I can show them how it works. We'd just need to put in the current colors, and then use the tool to go one shade lighter or darker. We'll then check how it looks and go from there.

Contribution

I'd be happy to do this if no one has interest :)

@andrewtavis andrewtavis added good first issue Good for newcomers help wanted Extra attention is needed design Relates to UX/UI designs blocked Another issue is blocking -priority- High priority and removed blocked Another issue is blocking labels Aug 13, 2022
@andrewtavis
Copy link
Member Author

@SaurabhJamadagni, all I did here was make the dark mode colors one shade lighter and the light mode colors one shade darker :) Let me know if you think the new versions work 😊

@andrewtavis andrewtavis self-assigned this Apr 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
-priority- High priority design Relates to UX/UI designs good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

1 participant