Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Deleted] Allow for selected text deletion #205

Closed
2 tasks done
andrewtavis opened this issue Sep 10, 2022 · 1 comment
Closed
2 tasks done

[Deleted] Allow for selected text deletion #205

andrewtavis opened this issue Sep 10, 2022 · 1 comment
Labels
feature New feature or request good first issue Good for newcomers help wanted Extra attention is needed wontfix This will not be worked on

Comments

@andrewtavis
Copy link
Member

Terms

Description

As mentioned in #188, Scribe currently doesn't have a feature where the user can select text and delete it. This feature would be implemented in handleDeleteButtonPressed() of keyboardViewController.swift using a check based on the selected text of the proxy, where if this text would also need a guard function likely:

guard
  selectedText = proxy.selectedText ?? ""
  !selectedText.isEmpty
else {
  return
}

Contribution

Happy to work on this with people or direct someone who wants to contribute :)
@andrewtavis andrewtavis added feature New feature or request good first issue Good for newcomers help wanted Extra attention is needed labels Sep 10, 2022
@andrewtavis andrewtavis mentioned this issue Sep 10, 2022
Closed
15 tasks
@andrewtavis andrewtavis changed the title Allow for selected text deletion [deleted] Allow for selected text deletion Sep 10, 2022
@andrewtavis
Copy link
Member Author

This issue was actually fixed in d69bad8 :)

@andrewtavis andrewtavis added the wontfix This will not be worked on label Apr 7, 2023
@andrewtavis andrewtavis changed the title [deleted] Allow for selected text deletion [Deleted] Allow for selected text deletion Feb 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature New feature or request good first issue Good for newcomers help wanted Extra attention is needed wontfix This will not be worked on
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@andrewtavis