Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvement in CSA measures with T2w images #71

Closed
PaulBautin opened this issue Sep 4, 2020 · 5 comments
Closed

Improvement in CSA measures with T2w images #71

PaulBautin opened this issue Sep 4, 2020 · 5 comments

Comments

@PaulBautin
Copy link
Collaborator

PaulBautin commented Sep 4, 2020

I have noticed with the following figure that results with T2w images are closer to what we expected. Should we try to run process on T2w images? Any idea why changing the contrast changes results?
(Edit: i only have T2w manual labeled images in my data-multi-subject local dataset)

fig_boxplot_atrophy

@jcohenadad
Copy link
Member

nice!

Edit: i only have T2w manual labeled images in my data-multi-subject local dataset

both T1w and T2w are available on the git-annex repos since this PR: spine-generic/data-multi-subject#15

@jcohenadad
Copy link
Member

but: the argument about not using the manual segs for the rescale=1 still holds (so i would fix that before launching with T2w)

@PaulBautin
Copy link
Collaborator Author

PaulBautin commented Sep 7, 2020

I have the results and they look good!
fig_boxplot_atrophy

Concerns:

@jcohenadad
Copy link
Member

Fantastic news @PaulBautin !!!🏅

I had to drop a certain number of dataframe rows(about 600 out of 187200), the problem seems a little different than spinalcordtoolbox/spinalcordtoolbox#2864.

why did you have to? could you document the error you are experiencing?

Why did T1w images have underestimated csa after rescaling? Still investigating.

indeed, this is puzzling 🤔

@PaulBautin
Copy link
Collaborator Author

Closing Issue: I've tested dfb4801 on Compute Canada and results are in line with what we found last time (without having to drop any dataframe rows).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants