Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Angular 17 Detected Routes but not rendering them. #1677

Open
jasonc624 opened this issue May 1, 2024 · 2 comments
Open

Angular 17 Detected Routes but not rendering them. #1677

jasonc624 opened this issue May 1, 2024 · 2 comments
Labels
bug Something isn't working

Comments

@jasonc624
Copy link

jasonc624 commented May 1, 2024

🐞 Bug report

Description

This code use to work but somewhere along the line whilst upgrading to 17 it stopped working. All components in the "landing" project have been converted to modules from standalone components.

🔬 Minimal Reproduction

npx scully --project landing --host='0.0.0.0' --scanRoutes --no-warning --showGuessError --showBrowser=false --pluginsError=false --logSeverity=normal

💻Your Environment

Node 20

Angular Version:
^17.0.8


    "@angular/cdk": "^17.0.4",
    "@angular/common": "^17.0.8",
    "@angular/compiler": "^17.0.8",
    "@angular/core": "^17.0.8",
    "@angular/fire": "17.0.0",

Scully Version:
^2.1.41 & 2.1.42


    "@scullyio/init": "^2.1.41",
    "@scullyio/ng-lib": "^2.1.41",
    "@scullyio/platform-server": "^2.1.41",
    "@scullyio/scully": "^2.1.41",
    "@scullyio/scully-plugin-puppeteer": "^2.1.0",

Scully Config scully.landing.config.ts



export const config: ScullyConfig = {
  puppeteerLaunchOptions: {
    args: [
      "--disable-gpu",
      "--renderer",
      "--no-sandbox",
      "--no-service-autorun",
      "--no-experiments",
      "--no-default-browser-check",
      "--disable-dev-shm-usage",
      "--disable-setuid-sandbox",
      "--no-first-run",
      "--no-zygote",
      "--single-process",
      "--disable-extensions",
      "--user-agent='Scully Navigator'",
      "--disable-headless-warning",
    ],
    headless: true,
  },
  projectRoot: "./projects/landing/src",
  projectName: "landing",
  distFolder: "./dist/landing", // output directory of your Angular build artifacts
  outDir: "./dist/static", // directory for scully build artifacts
  defaultPostRenderers: postRenderers,
  routes: {
    "/v/:id": {
      type: "json",
      id: {
        url: vanityUrl,
        property: "id",
      },
    },
  },
};

Discovery Happens

Screenshot 2024-05-01 at 6 29 18 PM

Rendering does not

Screenshot 2024-05-01 at 6 30 50 PM

@jasonc624 jasonc624 added the bug Something isn't working label May 1, 2024
@jasonc624
Copy link
Author

Is there any alternatives to scully?

@KaliaHayes
Copy link

Is there any alternatives to scully?

Fortunately, there is! I would recommend checking out Analog, the Angular meta-framework. It’s new, extremely well maintained, and constantly being improved.

The developer experience is fantastic, as well.

Hope it fits your needs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants