Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLs without me in attention set are listed as "Needing Attention" #42

Open
studgeek opened this issue Dec 8, 2021 · 4 comments
Open

Comments

@studgeek
Copy link

studgeek commented Dec 8, 2021

I have CLs without me in the attention set being listed as "Needing Attention". They are newly uploaded CLs without any reviewers. I do have "Only use Attention Set to judge required attention" set.

Unfortunately the example commits I have are all in a Google internal repo. I email you them directly. Thx!

@justinlulejian
Copy link

I'm seeing this issue in the public chromium Gerrit and can reproduce it. I'm the owner of the CL, but when I'm not listed in the attention set they still show as needing my attention in the extension. At the current moment I'm actually in the attention set, but multiple hours went by earlier today where this issue was true.

@justinlulejian
Copy link

Here's a screenshot showing where I'm not in the attention set, but the extension still lists the CL as needing my attention.
Screen Shot 2022-09-28 at 2 37 55 PM

@sdefresne
Copy link
Owner

The extension only fetches the information from gerrit every five minutes and then caches the result. Is it possible that the attention set changed less than five minutes ago?

@justinlulejian
Copy link

The README says:

On click, it also polls the server to display the popup (and refresh the badge).

So does that poll not invalidate the cache of the result?

Nonetheless, for the example in the screenshot, it's been over two hours of not being in the attention set and it still lists the CL as requiring attention.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants