Skip to content
This repository has been archived by the owner on Feb 18, 2021. It is now read-only.

Add a download method #7

Open
noamt opened this issue Mar 10, 2014 · 3 comments
Open

Add a download method #7

noamt opened this issue Mar 10, 2014 · 3 comments

Comments

@noamt
Copy link
Contributor

noamt commented Mar 10, 2014

In order for me to use the SDK client for the SGVM project, I also need net.gvmtool.client.GvmClient to provide a method that downloads a candidate distribution.

I was going to create a pull request for this, but I've noticed that the groovy-wslite client automatically loads the response data to memory; Grails distributions may reach ~100MB, so I'm not so sure it's a good idea.

Thoughts?

@pledbrook
Copy link

If you have a URL representing a binary download, why not just use the standard URL class? That's what Lazybones does.

@noamt
Copy link
Contributor Author

noamt commented Mar 10, 2014

Thanks, that's a good idea.
If I'm not mistaken, the GVM service redirects the request to the real download URL, so handling it might get a little ugly, but it's a start.

@noamt
Copy link
Contributor Author

noamt commented Mar 11, 2014

OK, redirection is actually handled well; I'll open a pull request.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants