-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Transient loop considerations #1
Comments
I am over the phone now, but
|
|
|
Am i missing something? |
oh I just realized that there is no problem if we go further than Lines 284 to 287 in d80ca8a
The problem would be the opposite, if we advance less than wanted, i.e. we do not reach |
I am seeinng https://seamplex.com/wasora/doc/realbook/004-exp/ which you can find in the doc/realbook repo and everything works as expected in the |
Are these lines:
wasora/src/wasora.c
Lines 303 to 304 in d80ca8a
correct?
I see the following issues:
ida_step_t_new
being set? It is going to be replaced when callingIDASolve
.IDASolve
should bewasora_var(wasora_special_var(time)) + wasora_var(wasora_special_var(min_dt))
, notwasora_var(wasora_special_var(dt))
. The User Documentation for IDA says that this argument corresponds to the next time at which a computed solution is desired. However, if theIDA_ONE_STEP
mode is set (as in this case), this variable is used on the first call only, and only to get the direction and rough scale of the independent variable. I still believe it should be set as recommended.Thanks and regards,
Ramiro.
The text was updated successfully, but these errors were encountered: