Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Radio: is-invalid #1605

Open
1 task done
SEBEric opened this issue Sep 23, 2024 · 1 comment
Open
1 task done

Radio: is-invalid #1605

SEBEric opened this issue Sep 23, 2024 · 1 comment
Labels
Comp: Radio Type: Bug Something isn't working

Comments

@SEBEric
Copy link

SEBEric commented Sep 23, 2024

Bug already reported?

  • I confirm that I have checked if the bug already has been reported

For which framework/library you are reporting the bug

No response

Component name

radiobutton

Description

invalid radiobuttons looks the same (but they do get the class 'is-invalid') in chlorophyll

Steps To Reproduce

go to https://storybook.seb.io/latest/chlorophyll/?path=/story/components-form-elements-radio-button--radiobutton&args=text1:Radiobutton+122;validation:is-invalid and take a look

Current Behaviour

Expected Behaviour

@SEBEric SEBEric added the Type: Bug Something isn't working label Sep 23, 2024
@EldRoos EldRoos changed the title is-invalid for radiobuttons Radio-button: is-invalid Sep 26, 2024
@EldRoos
Copy link
Contributor

EldRoos commented Sep 26, 2024

In this React RadioGroup example the red border comes because the outer div (2 steps out) have the class is-invalid.
https://storybook.seb.io/latest/react/iframe.html?viewMode=docs&id=components-form-radiogroup--docs&args=#validation

Edit: Ok in the design the circle of the radio also becomes red. So this need to be changed in code.

@EldRoos EldRoos changed the title Radio-button: is-invalid Radio: is-invalid Sep 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Comp: Radio Type: Bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants