Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HOTFIX: cannot bind to packed field #28

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jonathanschilling
Copy link

Fixes #23 by cast to uint64& in ppc_fpu.cc and ppc_mmu.cc.

Reference for idea on how to fix this:
https://stackoverflow.com/questions/27491432/why-cant-i-return-a-reference-to-a-packed-field#comment43418701_27491432

@puellanivis
Copy link

🤔 Do we even need to pack these fields? This is a singleton struct, so, it’s not like packing the fields would be saving us lots of memory, right?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

GCC stopped permitting referencing a packed field.
2 participants