Property 'includes' of object is not a function

[croban]

Inside 3.0.0-beta-2049 Version

The code below throws Exception Jint.Runtime.JavaScriptException : Property 'includes' of object is not a function

            var employees = new List<string>{ "test1", "test2" };

            var engine = new Engine(options => {
            });

            engine.Execute(@"function myFunction(employees) {
               return employees.includes('test1');
            }");
            var updatedEmployees = engine.Invoke("myFunction", JsValue.FromObject(engine, employees)).ToObject() as bool?;
            
            Assert.IsTrue(updatedEmployees);

Expected behavior

CLR Type List<string> should be converted to JS Array or we have to manually specify converter for List?

[lahma]

Jint only automatically handles arrays to JS array conversion as it's safe as being fixed size. Either call ToArray() when setting value to engine or modify options object wrapped to set different prototype.

jint/Jint.Tests/Runtime/InteropTests.cs

Lines 848 to 879 in db73cad

	public void CanAddArrayPrototypeForArrayLikeClrObjects()
	{
	var e = new Engine(cfg => cfg
	.AllowClr(typeof(Person).Assembly)
	.SetWrapObjectHandler((engine, target) =>
	{
	var instance = new ObjectWrapper(engine, target);
	if (instance.IsArrayLike)
	{
	instance.SetPrototypeOf(engine.Realm.Intrinsics.Array.PrototypeObject);
	}
	return instance;
	})
	);
	var person = new Person
	{
	Age = 12,
	Name = "John"
	};
	dynamic obj = new
	{
	values = new ReadOnlyList(person)
	};
	e.SetValue("o", obj);
	var name = e.Evaluate("o.values.filter(x => x.age == 12)[0].name").ToString();
	Assert.Equal("John", name);
	}

[croban]

Okay understand, I've helped my self with this:

public class ListConverter : IObjectConverter
{
    public bool TryConvert(Engine engine, object value, out JsValue? result)
    {
        if (value.GetType().IsGenericType && value is IList temp)
        {
            object[]? arr = new object[temp.Count];
            temp.CopyTo(arr, 0);
            result = JsValue.FromObject(engine, arr);
            return true;
        }

        result = null;
        return false;
    }
}

[croban]

Your solution is pretty slick! I'm still getting the hang of the library, so I need to delve deeper. The SetWrapObjectHandler function seems like a bit of magic to me.