Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

This crates needs to be archived, and should redirect to web-time #52

Closed
erwanvivien opened this issue Aug 28, 2023 · 14 comments
Closed

Comments

@erwanvivien
Copy link

Alternative is to change to web-time

@djc
Copy link

djc commented Feb 10, 2024

@sebcrozet do you think think it might make sense to put out an informational advisory to make it clear this crate is no longer being maintained? Would be nice to inform downstream users.

@TheMartianObserver
Copy link

@djc Given the extensive use of this crate (per stats on crates.io) and the lack of maintenance, seems prudent to submit this crate to Rustsec's database as unmaintained (certainly meets the Unmaintained Crate policy timeline thresholds).

@sebcrozet Please let us know if you plan to continue maintenance! Will likely submit this in the next week or so.

@sebcrozet
Copy link
Owner

sebcrozet commented Mar 3, 2024

@TheMartianObserver I don’t expect to have much time maintaining this crate unfortunately. So I am happy to provide maintenance access to a volunteer. I am otherwise OK with marking this as unmaintained.

@TheMartianObserver
Copy link

@TheMartianObserver I don’t expect to have much time maintaining this crate unfortunately. So I am happy to provide maintenance access to a volunteer. I am otherwise OK with marking this as unmaintained.

Thank you for the response, and completely understand about the time commitment.

Unfortunately, given that time-web exists with effectively the same API and a number of other crates have already shifted to that, I think it's probably best to archive this repo and mark it as unmaintained.

@Captainfl4me
Copy link

The main problem with web_time is that is does not support wasm32-unknown-emscripten target. Any known solutions ?

@sebcrozet
Copy link
Owner

I marked the crate as unmaintained on the readme and cargo badge.

@erwanvivien
Copy link
Author

Thanks for the good work seb 🙏

@daxpedda
Copy link

daxpedda commented May 21, 2024

The main problem with web_time is that is does not support wasm32-unknown-emscripten target. Any known solutions ?

AFAIK wasm32-unknown-emscripten doesn't need a polyfill, Std should work just fine. Therefore web-time, which in this case just re-exports Std, should work as well.

EDIT: Nope, I was wrong, wasm32-unknown-emscriptens Std implementation of time panics as well. I'm looking into if this in scope for web-time.

EDIT 2: My bad, I forgot that Emscripten falls under cfg(unix). Just tried it as well, Std works just fine, therefore web-time works as well.

@madsmtm
Copy link

madsmtm commented Sep 1, 2024

I've submitted an informational advisory to the database in rustsec/advisory-db#2056.

Another thing to do would be to add something like #![deprecated = "use the `web-time` crate instead"], that'd probably be more successful in getting people migrated.

A final option would be to release v0.2 as just pub use web_time::*;, that'd at least avoid people having updated dependencies.

These are not mutually exclusive.

@hrxi
Copy link

hrxi commented Nov 14, 2024

Another thing to do would be to add something like #![deprecated = "use the `web-time` crate instead"], that'd probably be more successful in getting people migrated.

Why is that necessary? There's no security vulnerability in this crate, is there? Anyone who uses it can continue to do so, unless they hit a bug and will come to this issue tracker and see that it's unmaintained.

@madsmtm
Copy link

madsmtm commented Nov 14, 2024

Another thing to do would be to add something like #![deprecated = "use the `web-time` crate instead"], that'd probably be more successful in getting people migrated.

Why is that necessary? There's no security vulnerability in this crate, is there? Anyone who uses it can continue to do so, unless they hit a bug and will come to this issue tracker and see that it's unmaintained.

It's not necessary, just a nicety, hence why I didn't open a new issue for it.

@hrxi
Copy link

hrxi commented Nov 14, 2024

Sorry, i meant: Why is it necessary (or desirable) to make people migrate? That mostly causes busy work and if this crate works well for them, why should you create busy work?

@madsmtm
Copy link

madsmtm commented Nov 14, 2024

I hope we can agree in general that it's desirable to get people to move to maintained alternatives, even when no current security issues exist?

In this particular case, I agree that it's not really an issue (yet, at least, though it might be once wasm-bindgen releases the next breaking version), the crate is fairly small.
I'm more in favour of other option anyhow (releasing a new version with pub use web_time::*;).

@hrxi
Copy link

hrxi commented Nov 14, 2024

I hope we can agree in general that it's desirable to get people to move to maintained alternatives

Not really. In the case of a feature-complete crate with no bugs that affect you, it's very sensible to not take the churn to switch to new dependencies every time a crate becomes unmaintained.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

8 participants