-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
This crates needs to be archived, and should redirect to web-time #52
Comments
@sebcrozet do you think think it might make sense to put out an informational advisory to make it clear this crate is no longer being maintained? Would be nice to inform downstream users. |
@djc Given the extensive use of this crate (per stats on crates.io) and the lack of maintenance, seems prudent to submit this crate to Rustsec's database as unmaintained (certainly meets the Unmaintained Crate policy timeline thresholds). @sebcrozet Please let us know if you plan to continue maintenance! Will likely submit this in the next week or so. |
@TheMartianObserver I don’t expect to have much time maintaining this crate unfortunately. So I am happy to provide maintenance access to a volunteer. I am otherwise OK with marking this as unmaintained. |
Thank you for the response, and completely understand about the time commitment. Unfortunately, given that time-web exists with effectively the same API and a number of other crates have already shifted to that, I think it's probably best to archive this repo and mark it as unmaintained. |
The main problem with web_time is that is does not support |
I marked the crate as unmaintained on the readme and cargo badge. |
Thanks for the good work seb 🙏 |
AFAIK EDIT: Nope, I was wrong, EDIT 2: My bad, I forgot that Emscripten falls under |
See sebcrozet/instant#52 Pull-Request: #5347.
I've submitted an informational advisory to the database in rustsec/advisory-db#2056. Another thing to do would be to add something like A final option would be to release These are not mutually exclusive. |
See sebcrozet/instant#52 Pull-Request: libp2p#5347.
Why is that necessary? There's no security vulnerability in this crate, is there? Anyone who uses it can continue to do so, unless they hit a bug and will come to this issue tracker and see that it's unmaintained. |
It's not necessary, just a nicety, hence why I didn't open a new issue for it. |
Sorry, i meant: Why is it necessary (or desirable) to make people migrate? That mostly causes busy work and if this crate works well for them, why should you create busy work? |
I hope we can agree in general that it's desirable to get people to move to maintained alternatives, even when no current security issues exist? In this particular case, I agree that it's not really an issue (yet, at least, though it might be once |
Not really. In the case of a feature-complete crate with no bugs that affect you, it's very sensible to not take the churn to switch to new dependencies every time a crate becomes unmaintained. |
SystemTime::elapsed()
is broken #49Performance
Cache the performance object #21Alternative is to change to
web-time
The text was updated successfully, but these errors were encountered: