Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2018 devices #88

Open
skuske opened this issue Sep 13, 2018 · 14 comments
Open

2018 devices #88

skuske opened this issue Sep 13, 2018 · 14 comments

Comments

@skuske
Copy link

skuske commented Sep 13, 2018

When will this support the new 2018 devices? Thanks.

@fabiosoft
Copy link

up

@xuning0
Copy link

xuning0 commented Sep 14, 2018

+1

3 similar comments
@raulrom13
Copy link

+1

@andforce
Copy link

+1

@mqch295
Copy link

mqch295 commented Sep 17, 2018

+1

@cguess
Copy link

cguess commented Sep 18, 2018

There's two pull requests implementing these changes (I'm partial to my own #90, but either will mostly do).

Feel free to set your pod file to use my fork:
pod 'SDVersion', git: 'https://github.com/cguess/SDVersion'
while waiting for one of them to be accepted.

@skuske
Copy link
Author

skuske commented Sep 18, 2018

@cguess

Cool, thanks. What about the new Watch devices?

@jyhud
Copy link

jyhud commented Sep 18, 2018

+1

@cguess
Copy link

cguess commented Sep 18, 2018

@cguess

Cool, thanks. What about the new Watch devices?

Honestly @skuske, I forgot. I haven't done a ton of WatchOS development but I'll try and get a fix in ASAP.

@CaiChenghan
Copy link

@cguess cool

@cguess
Copy link

cguess commented Sep 19, 2018

@skuske it's now updated with the new 40mm and 44mm watch sizes. I'm guessing (intelligently) on the watch models, since neither I nor anyone else has them yet, but it should be solid.

@JaterLee
Copy link

JaterLee commented Nov 3, 2018

@skuske it's now updated with the new 40mm and 44mm watch sizes. I'm guessing (intelligently) on the watch models, since neither I nor anyone else has them yet, but it should be solid.

There's two pull requests implementing these changes (I'm partial to my own #90, but either will mostly do).

Feel free to set your pod file to use my fork:
pod 'SDVersion', git: 'https://github.com/cguess/SDVersion'
while waiting for one of them to be accepted.

screenHeight = [[UIScreen mainScreen] nativeBounds].size.height this wrong In the case of using the plus series

@poholo
Copy link

poholo commented Jan 5, 2019

@cguess How can I use your repo of a podspec ?
s.dependency 'SDVersion', git: 'https://github.com/cguess/SDVersion'

@cguess
Copy link

cguess commented Jan 7, 2019

@poholo sorry about the delay with the holidays. I'll look into it ASAP

Repository owner deleted a comment from poholo Apr 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests