Change ID field to use little-endian byte order #4629
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4629 +/- ##
==========================================
- Coverage 81.39% 80.66% -0.73%
==========================================
Files 359 341 -18
Lines 86052 85781 -271
==========================================
- Hits 70045 69199 -846
- Misses 16007 16582 +575
|
|
Thanks for the PR ! Would you mind adding a unit test ? |
satveerbrar
force-pushed
the
bugfix/4624
branch
from
da6f7ee to
e4ec015
Compare
|
@gpotter2 Can you review unit test? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change encode/decode using little-endian. Duration values now match with Wireshark.
fixes #4624