DotStar LED's #122
Open
DotStar LED's #122
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I am a total novice with Python; although apa102 is installed, I could only get the apa102 module to load by copying tinue's 'driver' and 'colorschemes' folders into modular-led-workstation-master folder then calling 'from driver import apa102'. Have'nt got further than this atm, 'cause audio playing up and need to sort. |
ChasonDeshotel
suggested changes
Sep 17, 2020
Comment on lines
+176
to
+179
| elif self.getConfiguration(CONFIG_DEVICE) == devices.DotStar.__name__: | ||
| device = devices.DotStar( | ||
| self.getConfiguration(CONFIG_NUM_PIXELS), self.getConfiguration(CONFIG_NUM_ROWS), | ||
| self.getConfiguration(CONFIG_DEVICE_CANDY_SERVER)) |
There was a problem hiding this comment.
This violates DRY. I suggest using getattr to instantiante the class dynamically.
def createOutputDevice(self):
device = getattr(devices, self.getConfiguration(CONFIG_DEVICE))(
self.getConfiguration(CONFIG_NUM_PIXELS), self.getConfiguration(CONFIG_NUM_ROWS))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR resolves #121.
Server and Demo can now be started with
-D DotStarfor DotStar LED device.