Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update reference to global to be globalThis #3

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

vrugtehagel
Copy link

@vrugtehagel vrugtehagel commented Oct 28, 2024

This specific reference to global is Node-specific. According to the Node globals documentation, this should be updated to globalThis. After this, the package becomes browser-friendly which fixes an issue with bundling certain integrations manually.

Resolves segmentio/analytics.js-integrations#807.

@seg-atlantis-prod
Copy link

Atlantis commands can't be run on fork pull requests. To enable, set --allow-fork-prs or, to disable this message, set --silence-fork-pr-errors

@seg-atlantis-prod
Copy link

Error parsing command: EOF found when expecting closing quote

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Manually bundling GTM integration causes error
1 participant