Commits on Jun 5, 2024

1. chore: Add golangci-lint and fix most issues …

   The new `make lint` target runs golangci-lint if installed locally. It
   is not (yet) required for a passing build.
   
   Most issues reported by golangci-lint are resolved. Some interesting
   ones:
   
   * Missing error checking is added for exporting to a properties file and
     to Terraform variables.
   * Unused functions are removed: stringInSlice, S3KMSStore.readObject.
   * Unused variables are removed: validKeyFormat.
   * Write operations used to set up store tests now have their errors
     checked. If a setup write fails, the test immediately fails.
   
   Unresolved issues:
   
   * Use of EndpointResolverWithOptions
   * Missing error checks for flushing, syncing, and closing a file
     created by the export command

   

   bhavanki committed Jun 5, 2024
   Configuration menu

   • View commit details
   • Copy full SHA for a693d26
   • Browse repository at this point

   Copy the full SHA

   a693d26 View commit details

   Browse the repository at this point in the history