Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nit: We should make this list of tags a list of reusable enums #53

Closed
Cordtus opened this issue May 9, 2024 · 1 comment
Closed

Nit: We should make this list of tags a list of reusable enums #53

Cordtus opened this issue May 9, 2024 · 1 comment
Assignees

Comments

@Cordtus
Copy link
Contributor

Cordtus commented May 9, 2024

          Nit: We should make this list of tags a list of reusable enums
export enum Tag {
    WALLET = 'Wallet',
    NATIVE = 'Native',
    ...
}

Then for each app we can do tags: [Tag.WALLET, Tag.NATIVE] and not have to worry about ensuring all the apps have the same spelling, case etc when we add more in the future.

Originally posted by @mj850 in #52 (comment)

@cordt-sei cordt-sei self-assigned this May 12, 2024
@cordt-sei
Copy link
Contributor

Fixed in Devrel branch upon merging .

Additionally added a doc for contributing to the ecosystem apps page at ./eco-apps.mdx

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants