Ridden Entities Deleted Upon Teleport

[ZorudaRinku]

Ridden entities are completely deleted upon entering a portal
You mentioned they might be going to the nether but the nether is disabled on this server so potentially it's just deleting them

Purpur 1.17.1 Build 1428
Waterfall for 1.17.1
Advanced Portals version 0.7.1

Server.properties

allow-nether=false

bukkit.yml

allow-end: false

2021-12-11.17-30-45_Trim.mp4

Start of convo:
https://discord.com/channels/168282484037910528/249757652664582161/919122169705938974

Portal on server 1:

Wild:
  world: world
  triggerblock: WATER
  destination: wildspawn1
  bungee: Wild
  pos1:
    X: 15
    Y: 68
    Z: 15
  pos2:
    X: -15
    Y: 62
    Z: -15

Destination on server 2:

wildspawn1:
  world: world
  pos:
    X: 0.5
    Y: 63.0
    Z: 5.5
    pitch: 0
    yaw: 0

Config on server 1:

ConfigVersion: 0.5.13
UseOnlyServerMadeAxe: false
AxeItemId: IRON_AXE
CanBuildPortalBlock: true
PortalProtection: true
PortalProtectionArea: 5
DefaultPortalTriggerBlock: PORTAL
StopWaterFlow: false
ShowSelectionBlockID: RED_STAINED_GLASS
WarpParticles: 1
WarpSound: 1
ShowBungeeWarpMessage: false
ShowSelectionShowDuration: 10
WarpMessageDisplay: 2
UseWarpPrefix: true
UseCustomPrefix: false
CustomPrefix: '&a[&eAdvancedPortals&a]'
CustomPrefixFail: '&c[&7AdvancedPortals&c]'
BlockSpectatorMode: false
PortalCooldown: 5
ThrowbackAmount: 0.7
DisableGatewayBeam: true
CommandLevels: opcb
CommandLogs: true
ForceEnableProxySupport: false
ProxyTeleportDelay: 0

[sekwah41]

Advanced-Portals/src/main/java/com/sekwah/advancedportals/bukkit/destinations/Destination.java

Lines 146 to 154 in 2207324

	if (player.getVehicle() != null && TELEPORT_RIDING) {
	riding.eject();
	riding.teleport(loc, PlayerTeleportEvent.TeleportCause.PLUGIN);
	player.teleport(loc, PlayerTeleportEvent.TeleportCause.PLUGIN);
	riding.setPassenger(player);
	} else {
	player.teleport(loc, PlayerTeleportEvent.TeleportCause.PLUGIN);

I believe there is some old code trying to teleport entities though I need to take a look at making sure it doesn't kill non-owned entities and generally rework how it tries to handle them.

I think in this case as the pig isn't in an enclosed space it may be despawning. I forget if saddled pigs are flagged to never despawn so testing with a horse would be good but deffo need to test with both owned and unowned entities.