-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add explanation of low code-cov #26
Comments
Try and find a way to get coverage metrics that actually tell us which assertions have high/low code coverage. As it is the coverage stats are not super helpful |
Added a test to check a reasonable number of tests per assertion has been - don't think we can do much more than that for now. Ensure some explanation of the problem is written somewhere on the readme, then we should close |
Actually, a bunch of our code cov could be amplified by adding assertions on many of the lower level functions used in assertion generation. Might be worth doing this. While testing the assertion interface itself is definitely the best approach running pretty much identical tests on the the underlying functions where possible can't hurt |
Ok thorough review of assertions test coverage reveals that either past me was a fool or something in how test-coverage is computed has changed and our assertion creation lines don't count as towards our 'missing' test coverage - meaning that even though testing the assertions themselves doesn't get us great coverage, testing the underlying functions should get us pretty good coverage. Going to bump up the unit testing of non-exported non-assertion functions and then close this issue |
Robust assertion packages should have extremely high unit-test coverage
Unfortunately, because assertion function from this package are created with a function
assert_create
the unit tests aren't considered to cover the assertion creation statementsThe text was updated successfully, but these errors were encountered: