Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add assertion: assert_length #32

Closed
selkamand opened this issue Feb 6, 2023 · 3 comments · Fixed by #118
Closed

Add assertion: assert_length #32

selkamand opened this issue Feb 6, 2023 · 3 comments · Fixed by #118

Comments

@selkamand
Copy link
Owner

No description provided.

@selkamand
Copy link
Owner Author

selkamand commented Feb 24, 2023 •
edited
Loading

I think this should have several versions:

including
assert_length
assert_length_gt
assert_length_gte
assert_length_lt
assert_length_lte

@selkamand
Copy link
Owner Author

If this is the naming convention, then assert_greater_than should be assert_gt. Although perhaps its to use the abbreviations for purposes like the above ... not sure yet

selkamand added a commit that referenced this issue Nov 9, 2024
@selkamand
feat: added assert_length and friends
6eedc0f 
Resolves issue #32
@selkamand selkamand linked a pull request Nov 9, 2024 that will close this issue
32 add assertion assert length #118
Merged
@selkamand
Copy link
Owner Author

Ended up deciding to go with the unabbreviated versions. Assertions tend to be 1perline in codebases anyway so a longer line is not so bad if it increases clarity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

32 add assertion assert length selkamand/assertions
1 participant
@selkamand