Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

better debug messages to the math-parser print #66

Open
evykassirer opened this issue Aug 7, 2017 · 6 comments
Open

better debug messages to the math-parser print #66

evykassirer opened this issue Aug 7, 2017 · 6 comments

Comments

@evykassirer
Copy link
Contributor

when the node isn't recognized, it'd be nice to print some tip to what the node looks like

@ericluap
Copy link
Contributor

ericluap commented Aug 7, 2017

Do you mean when it just prints out 'extra input not recognized'?

@evykassirer
Copy link
Contributor Author

I think I saw "node not recognized" but that place seems good to add detail to as well! :)

@ericluap
Copy link
Contributor

ericluap commented Aug 8, 2017

With those, the node that wasn't recognized is also printed. I think the only place it isn't printed out is with the extra input error.

@evykassirer
Copy link
Contributor Author

I believe it was this line

throw new Error('unrecognized node')

@evykassirer
Copy link
Contributor Author

the node is logged but not part of the error, so I couldn't see it

@ericluap
Copy link
Contributor

ericluap commented Aug 8, 2017

Ah ok, missed that one entirely.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants