Change verification key points in contract to constant #330
Assignees
Labels
feature 🚀
This is enhancing something existing or creating something new
good first issue
Good for newcomers
hacktoberfest
Encourages contributions to open source during Hacktoberfest.
Comments
saleel
added
the
feature 🚀
cedoor
added
good first issue
|
Hey @cedoor, would love to work on this ? Could you clarify the remaining tasks for this issue? Any additional context would be appreciated. Thanks! |
|
Hi @0xshikhar, this issue is part of #354. Let's sync here: #345 (comment) |
|
@jimmychu0807 please, leave a comment here. |
|
Hi |
Sure, got it |
jimmychu0807
added a commit
to jimmychu0807/semaphore
that referenced
this issue
Oct 16, 2024
…into a separate library (semaphore-protocol#330)
jimmychu0807
added a commit
to jimmychu0807/semaphore
that referenced
this issue
Oct 16, 2024
…into a separate library (semaphore-protocol#330)
7 tasks
jimmychu0807
added a commit
to jimmychu0807/semaphore
that referenced
this issue
Oct 16, 2024
cedoor
pushed a commit
that referenced
this issue
Oct 17, 2024
* refactor(scripts): added a script to convert bigint to hex * refactor(contracts): split SemaphoreVerifier verification key points into a separate library (#330) * chore(contracts): yarn format & lint * refactor(contracts): update SemaphoreVerifierKeyPts library to be internal re #330 * chore(contracts): update spacing * chore(contracts): updated per peer review and added invariant check for VerifierKeyPts lib * chore(contracts): update invariant check to revert with custom error
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The
VK_POINTSpoints variable storing the verification key points in the contract is not aconstant.The value will be stored in storage slots and would require reading every time. If this could be changed to a
constant, the value will be part of the bytecode and verification will be cheaper (and also better performance I think).Since this is an array it cannot be marked as constant directly, so other techniques need to be explored.
The text was updated successfully, but these errors were encountered: