Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor generate proof function when a group has only one member and tree depth 0 #805

Closed
2 tasks done
vplasencia opened this issue Jun 24, 2024 · 0 comments
Closed
2 tasks done
Assignees
Labels
documentation 📖 Improvements or additions to documentation refactoring ♻️ A code change that neither fixes a bug nor adds a feature

Comments

@vplasencia
Copy link
Member

vplasencia commented Jun 24, 2024

Description

When there is 1 member in the group and you want to generate a proof without passing the tree depth, there will be an error because tree depth 0 is not supported to generate a proof and one member is tree depth 0. It's true that in a group with 1 member there is no anonymity but for testing purposes it's better to also support tree depth 0 when generating a proof for groups with 1 member without passing the tree depth parameter.

Tasks:

More context: #804

@vplasencia vplasencia added documentation 📖 Improvements or additions to documentation refactoring ♻️ A code change that neither fixes a bug nor adds a feature labels Jun 24, 2024
@vplasencia vplasencia added this to the Semaphore V4 milestone Jun 24, 2024
@cedoor cedoor self-assigned this Jul 19, 2024
@vplasencia vplasencia self-assigned this Jul 25, 2024
@cedoor cedoor closed this as completed Aug 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation 📖 Improvements or additions to documentation refactoring ♻️ A code change that neither fixes a bug nor adds a feature
Projects
Status: ✔️ Done
Development

No branches or pull requests

2 participants