Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update UI code of cli-template-monorepo-ethers and cli-template-monorepo-subgraph #836

Open
vplasencia opened this issue Jul 24, 2024 · 4 comments · May be fixed by #841
Open

Update UI code of cli-template-monorepo-ethers and cli-template-monorepo-subgraph #836

vplasencia opened this issue Jul 24, 2024 · 4 comments · May be fixed by #841
Assignees
@yagopajarino
Labels
good first issue Good for newcomers refactoring ♻️ A code change that neither fixes a bug nor adds a feature

Comments

@vplasencia
Copy link
Member

Description

It would be nice to update the cli-template-monorepo-ethers and cli-template-monorepo-subgraph UI code with the same code as the boilerplate following the React good practices.

Boilerplate UI code: https://github.com/semaphore-protocol/boilerplate/tree/main/apps/web-app
@vplasencia vplasencia added good first issue Good for newcomers refactoring ♻️ A code change that neither fixes a bug nor adds a feature labels Jul 24, 2024
@yagopajarino
Copy link

Hi @vplasencia, I may be able to contribute with this refactoring. Could you assign it to me?

@vplasencia
Copy link
Member Author

Hey @yagopajarino ! Thank you. I just assigned you the issue. Let us know if you have any questions.

yagopajarino added a commit to yagopajarino/semaphore that referenced this issue Jul 28, 2024
@yagopajarino
refactor(cli-template-monorepo-ethers): update cli-template-monorepo-…
498ba16 
…ethers web app UI

re semaphore-protocol#836
yagopajarino added a commit to yagopajarino/semaphore that referenced this issue Jul 28, 2024
@yagopajarino
refactor(cli-template-monorepo-subgraph): update cli-template-monorep…
112bf90 
…o-subgraph web app UI

re semaphore-protocol#836
yagopajarino added a commit to yagopajarino/semaphore that referenced this issue Jul 28, 2024
@yagopajarino
refactor(cli-template-monorepo-subgraph): rename subgraph web app on …
5165a12 
…package.json

re semaphore-protocol#836
@yagopajarino yagopajarino linked a pull request Jul 28, 2024 that will close this issue
Open
7 tasks
@yagopajarino
Copy link

Hi @vplasencia, I summited the PR but looks like it's failing everywhere. However I tested it locally and worked fine.

I realized the new UI uses chakra components, therefore some new packages need to be installed but github actions don't allow me to do so.

image

Let me know what you think and what changes should I do

@vplasencia
Copy link
Member Author

Hey @yagopajarino thank you very much for the PR 🙏. I will take a look as soon as possible.

yagopajarino added a commit to yagopajarino/semaphore that referenced this issue Jul 30, 2024
@yagopajarino
refactor: update yarn.lock
a3d84f3 
re semaphore-protocol#836
yagopajarino added a commit to yagopajarino/semaphore that referenced this issue Aug 12, 2024
@yagopajarino
refactor: merge remote-tracking branch 'upstream/main'
020c087 
re semaphore-protocol#836
yagopajarino added a commit to yagopajarino/semaphore that referenced this issue Aug 12, 2024
@yagopajarino
chore: update cli monorepo package.json
23df12d 
re semaphore-protocol#836
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@yagopajarino yagopajarino

Labels
good first issue Good for newcomers refactoring ♻️ A code change that neither fixes a bug nor adds a feature
Projects
Semaphore Board
Status: 👀 In review
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update cli monorepo ethers and subgraph web app UI yagopajarino/semaphore
2 participants
@yagopajarino @vplasencia