Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement StringCodec and others using CombinedChannelDuplexHandler #13

Open
RoganDawes opened this issue Oct 30, 2020 · 1 comment
Open
Labels
good first issue Good for newcomers

Comments

@RoganDawes
Copy link
Collaborator

It's a bit annoying to have to add both a StringEncoder and a StringDecoder node to the graph (on both the server and client pipelines!). These can be amalgamated using CombinedChannelDuplexHandler into a single node. Possibly the best way to deal with this would be to create a new tab in the palette for bidirectional codecs.

Start looking around here: https://github.com/sensepost/mallet/blob/master/src/main/java/com/sensepost/mallet/swing/GraphEditor.java#L216

This should probably apply to more than just the StringEncoder/StringDecoder, the idea applies to any "bidirectional" codec pairs.

@RoganDawes RoganDawes added the good first issue Good for newcomers label Oct 30, 2020
@Tokarak
Copy link

Tokarak commented Jun 18, 2022

I feel like taking this on.
Fixed link for reference:

protocolPalette.addTemplate("StringDecoder",

edit:

protocolPalette.addTemplate("StringDecoder", IMAGE_ROUNDED, "rounded=1", 160, 120, createElement(xmlDocument,

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants