Install packages following modern standards and update tests #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CentOS 6 and Debian 7 are EOL. Add new versions of stuff to tests too.
There are still sometimes duplicate declaration issues, but this fixes it.
yakatz
force-pushed
the
bug/perl_installed
branch
from
79eccc6 to
d62585b
Compare
|
@yakatz I'm sorry, I completely missed this. Can you have a look at the tests? They completely fail on version 6. See: https://travis-ci.org/github/sensson/puppet-csf/jobs/742884891 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was not able to get the acceptance tests to run at all, but everything else looks like it works. I removed the EOL operating systems from the supported list and added new ones so the spec tests would run. I will look at upgrading the acceptance testing to run on the new OSes - they don't have vagrant images available anymore.
Closes #11