Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[react] Update React Version to latest (18) #387

Open
sdzhong opened this issue Jan 27, 2024 · 3 comments
Open

[react] Update React Version to latest (18) #387

sdzhong opened this issue Jan 27, 2024 · 3 comments

Comments

@sdzhong
Copy link
Contributor

sdzhong commented Jan 27, 2024

Currently at React 17

"react": "~17.0.2",

npm install --save react@latest

@sdzhong
Copy link
Contributor Author

sdzhong commented Jan 27, 2024

This will allow use of <Suspense> https://react.dev/reference/react/Suspense, which can be used when loading products.

@cstavitsky
Copy link
Contributor

cstavitsky commented Jan 29, 2024

Ah interesting, would the change be this?

We would wrap the product data in

<Suspense fallback={<Loader type="ThreeDots" color="#f6cfb2" height={150} width={150} />} > 
  ...product data... 
</Suspense>

? (Loader component taken from here)

@cstavitsky
Copy link
Contributor

Oh, I guess we have to make sure we meet these criteria:

Screenshot 2024-01-29 at 9 40 55 AM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants