Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[react] Click Breadcrumbs missing in Replays #412

Open
sdzhong opened this issue Mar 5, 2024 · 7 comments · May be fixed by #413
Open

[react] Click Breadcrumbs missing in Replays #412

sdzhong opened this issue Mar 5, 2024 · 7 comments · May be fixed by #413

Comments

@sdzhong
Copy link
Contributor

sdzhong commented Mar 5, 2024

image

@billyvg
Copy link

billyvg commented Mar 5, 2024

@mydea so it looks like npm and yarn handle this differently... when using yarn, it functions as expected where replay and @sentry/browser call the same instrumentation handler (utils/src/instrument/_handlers) and has the same handlers in scope.

However npm behaves differently and has them as separate modules.

(I had mentioned in Slack that this was due to outdated @sentry/webpack-plugin, but I tried yarn with the older version, and it seems to work fine). Not sure what the ideal solution is here

@billyvg
Copy link

billyvg commented Mar 5, 2024

npm version 10 also seems to work

@sdzhong sdzhong linked a pull request Mar 5, 2024 that will close this issue
@sdzhong sdzhong linked a pull request Mar 5, 2024 that will close this issue
@sdzhong
Copy link
Contributor Author

sdzhong commented Mar 6, 2024

@billyvg do you know if this is this due to an SDK bug or an NPM limitation?

@mydea
Copy link
Collaborator

mydea commented Mar 6, 2024

So, did you check if the versions in the lockfile were actually aligned @billyvg ?
AFAIK, as long as there is only a single version (!) of e.g. @sentry/utils in the lockfile, all packages should use the same and it should work. But if there are two different versions, stuff starts to fail this way.

@billyvg
Copy link

billyvg commented Mar 6, 2024

@mydea I did, we rm'd the lockfile (and node_modules) and re-generated it. npm v8 still fails, but v10 works as expected.

@mydea
Copy link
Collaborator

mydea commented Mar 6, 2024

Damn, that sucks! I wonder, if this is really the expected behavior of old npm, why we never heard of this before...

@sdzhong
Copy link
Contributor Author

sdzhong commented Mar 6, 2024

Damn, that sucks! I wonder, if this is really the expected behavior of old npm, why we never heard of this before...

Speaking for myself, it was simply not noticed for the many months that it's been available.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants