Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue #137: Develop MySQL Connector #142

Merged
merged 34 commits into from
Jan 17, 2025
Merged

Issue #137: Develop MySQL Connector #142

merged 34 commits into from
Jan 17, 2025

Conversation

SafaeAJ
Copy link
Contributor

@SafaeAJ SafaeAJ commented Nov 8, 2024

  • Added MySQL.yaml
  • Added database.yaml

Tested :

Capture d'écran 2024-11-08 143129
Capture d'écran 2024-11-08 142912
Capture d'écran 2024-11-08 143120

@SafaeAJ SafaeAJ self-assigned this Nov 8, 2024
@SafaeAJ SafaeAJ linked an issue Nov 8, 2024 that may be closed by this pull request
Added support for MySQL databases via JDBC #137
Closed
@SafaeAJ SafaeAJ requested a review from bertysentry November 8, 2024 14:45
@NassimBtk NassimBtk changed the title Issue #137: Create MySQL Connector Issue #137: Develop MySQL Connector Nov 8, 2024
NassimBtk
NassimBtk requested changes Nov 8, 2024
View reviewed changes
src/main/connector/database/Database/Database.yaml Outdated Show resolved Hide resolved
src/main/connector/database/Database/Database.yaml Outdated Show resolved Hide resolved
src/main/connector/database/Database/Database.yaml Outdated Show resolved Hide resolved
src/main/connector/database/Database/Database.yaml Outdated Show resolved Hide resolved
@NassimBtk
Copy link
Member

We need to update the MetricsHub Maven Plugin to add the support of SQL.

@NassimBtk
Copy link
Member

We need to update the MetricsHub Maven Plugin to add the support of SQL.

sentrysoftware/metricshub-connector-maven-plugin#68

@NassimBtk NassimBtk modified the milestone: 1.0.07 Nov 21, 2024
NassimBtk
NassimBtk requested changes Nov 25, 2024
View reviewed changes
src/main/connector/database/Database/Database.yaml Outdated Show resolved Hide resolved
src/main/connector/database/MySQL/MySQL.yaml Outdated Show resolved Hide resolved
src/main/connector/database/MySQL/MySQL.yaml Outdated Show resolved Hide resolved
src/main/connector/database/MySQL/MySQL.yaml Outdated Show resolved Hide resolved
src/main/connector/database/MySQL/MySQL.yaml Outdated Show resolved Hide resolved
@SafaeAJ
Issue #137: Develop MySQL Connector
3683f84 
* * Updated MySQL.yaml
@SafaeAJ
Issue #137: Develop MySQL Connector
447d7b7 
* * Updated MySQL.yaml
NassimBtk
NassimBtk reviewed Jan 15, 2025
View reviewed changes
src/main/connector/database/MySQL/MySQL.yaml Outdated Show resolved Hide resolved
src/main/connector/database/MySQL/MySQL.yaml Outdated Show resolved Hide resolved
src/main/connector/database/MySQL/MySQL.yaml Outdated Show resolved Hide resolved
src/main/connector/database/MySQL/MySQL.yaml Outdated Show resolved Hide resolved
src/main/connector/database/MySQL/MySQL.yaml Outdated Show resolved Hide resolved
src/main/connector/database/MySQL/MySQL.yaml Outdated Show resolved Hide resolved
src/main/connector/database/MySQL/MySQL.yaml Outdated Show resolved Hide resolved
@SafaeAJ
Issue #137: Develop MySQL Connector
2941a67 
* * Updated MySQL.yaml
@SafaeAJ
Issue #137: Develop MySQL Connector
6bd0746 
* Updated metric name
@SafaeAJ
Issue #137: Develop MySQL Connector
fda4cae 
* Updated metric unit
@SafaeAJ SafaeAJ requested a review from NassimBtk January 16, 2025 09:36
NassimBtk
NassimBtk approved these changes Jan 16, 2025
View reviewed changes
src/main/connector/database/MySQL/MySQL.yaml Outdated Show resolved Hide resolved
src/main/connector/database/MySQL/MySQL.yaml Outdated Show resolved Hide resolved
src/main/connector/database/MySQL/MySQL.yaml Outdated Show resolved Hide resolved
src/main/connector/database/MySQL/MySQL.yaml Outdated Show resolved Hide resolved
src/main/connector/database/MySQL/MySQL.yaml Outdated Show resolved Hide resolved
src/main/connector/database/MySQL/MySQL.yaml Outdated Show resolved Hide resolved
src/main/connector/database/MySQL/MySQL.yaml Outdated Show resolved Hide resolved
src/main/connector/database/MySQL/MySQL.yaml Outdated Show resolved Hide resolved
src/main/connector/database/MySQL/MySQL.yaml Outdated Show resolved Hide resolved
src/main/connector/database/MySQL/MySQL.yaml Show resolved Hide resolved
@NassimBtk NassimBtk modified the milestones: 1.0.07, 1.0.08 Jan 16, 2025
@SafaeAJ
Issue #137: Develop MySQL Connector
21cd0f9 
* Updated metric name
@SafaeAJ SafaeAJ requested a review from NassimBtk January 16, 2025 17:02
@NassimBtk
Copy link
Member

I think we are good now @bertysentry, what do you think😉?

@NassimBtk
Copy link
Member

Sorry one more change on the platform 😉

@SafaeAJ SafaeAJ requested a review from NassimBtk January 17, 2025 08:50
@NassimBtk NassimBtk removed this from the 1.0.08 milestone Jan 17, 2025
@NassimBtk NassimBtk merged commit 576a6bc into main Jan 17, 2025
1 check passed
@NassimBtk NassimBtk deleted the feature/issue-137-create-mysql-connector branch January 17, 2025 16:35
@bertysentry
Copy link
Member

Beautiful! 😊

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NassimBtk NassimBtk NassimBtk approved these changes

@MarcDouguedroit MarcDouguedroit Awaiting requested review from MarcDouguedroit

@TNohaic TNohaic Awaiting requested review from TNohaic

@bertysentry bertysentry Awaiting requested review from bertysentry

@NathalieLe NathalieLe Awaiting requested review from NathalieLe

Assignees

@SafaeAJ SafaeAJ

Labels
developer_tested The changes are tested by the developer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Added support for MySQL databases via JDBC
3 participants
@SafaeAJ @NassimBtk @bertysentry