Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BREAKING_CHANGE] Added support for multiple variable values for the same connector #435

Closed
11 of 13 tasks
CherfaElyes opened this issue Oct 2, 2024 · 0 comments · Fixed by #467
Closed
11 of 13 tasks
Assignees
Labels
documentation Improvements or additions to documentation enhancement New feature or request java
Milestone

Comments

@CherfaElyes
Copy link
Contributor

CherfaElyes commented Oct 2, 2024

Specification

Currently, it is possible to define connector variables values as follows:

resources:
  <host_id>:
    attributes:
      host.name: <hostname>
      host.type: linux
    protocols:
      ssh:
        username: <username>
        password: <password>
    variables:
      <connectorId>:
        <variableName>: <variableValue>

This does not allow to use the same connector more than once. To remedy, we would like to implement the following configuration in order to be able to use the same connector many times with different connector variables values:

  additionalConnectors:
    <CustomConnectorId1>: 
      uses: <ConnectorId> # If not specified, the default is the key name
      variables:
        <VariableName>: <VariableValue>
      force: false # default true
    <CustomConnectorId2>: 
      uses: <ConnectorId> # If not specified, the default is the key name
      variables:
        <VariableName>: <VariableValue>
      force: false # default true

To do

@CherfaElyes CherfaElyes added documentation Improvements or additions to documentation enhancement New feature or request java labels Oct 2, 2024
@CherfaElyes CherfaElyes added this to the v0.9.07 milestone Oct 2, 2024
@CherfaElyes CherfaElyes self-assigned this Oct 2, 2024
@CherfaElyes CherfaElyes removed this from the v0.9.07 milestone Oct 4, 2024
CherfaElyes added a commit that referenced this issue Oct 15, 2024
…ent connector variables

* Added the possibility to define additional connectors, which are connectors with variables where the user can customize variables values.
* It is possible to define many instances of the same connector, and this by customizing values for each instance.
* Updated unit tests to make sure everything is working.
* Tested the changes on MetricsHub.
* Updated the MetricsHub documentation to explain how to define and customize connector variables.
* Updated MetricsHub maven plugin to generate additionalConnectors configuration.
@NassimBtk NassimBtk added this to the 1.0.02 milestone Oct 22, 2024
@NassimBtk NassimBtk changed the title Add the possibility to use the same connector with different connector variables values [BREAKING_CHANGE] Add the possibility to use the same connector with different connector variables values Oct 22, 2024
CherfaElyes added a commit that referenced this issue Oct 25, 2024
…ent connector variables

* Refactored ConnectorVariablesLibraryParser for better clarity.
* Corrected some Javadoc errors.
* Moved some classes to a new package.
CherfaElyes added a commit that referenced this issue Oct 25, 2024
…ent connector variables

* Updated Documentation.
CherfaElyes added a commit that referenced this issue Oct 25, 2024
…ifferent connector variables

* Reformatted the code.
CherfaElyes added a commit that referenced this issue Oct 25, 2024
…ent connector variables

* Updated configure-monitoring.md
iguitton added a commit that referenced this issue Oct 28, 2024
…nt connector variables values

* Reviewed and updated the user documentation
@iguitton iguitton changed the title [BREAKING_CHANGE] Add the possibility to use the same connector with different connector variables values [BREAKING_CHANGE] Added the ability to use several connector variable values for a same connector Oct 28, 2024
@iguitton iguitton changed the title [BREAKING_CHANGE] Added the ability to use several connector variable values for a same connector [BREAKING_CHANGE] Added support for multiple variable values for the same connector Oct 28, 2024
iguitton added a commit that referenced this issue Oct 30, 2024
Fixed a typo
NassimBtk added a commit that referenced this issue Nov 4, 2024
connector variables

* Reformatted tables.
* Updated connector links to use relative paths.
NassimBtk added a commit that referenced this issue Nov 7, 2024
…-possibility-to-use-the-same-connector-with-different-connector-variables-values

Issue #435: Add the possibility to use the same connector with different connector variables
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request java
Projects
None yet
2 participants