Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for named groups in metadata extraction on ExternalParser #2062

Open
patrickdalla opened this issue Jan 26, 2024 · 3 comments
Open
Assignees

Comments

@patrickdalla
Copy link
Collaborator

Some advanced regex may include more than 2 groups, being some of the groups used only to filter the result, containing no useful information.
So, the use of the named groups "key" and "value" would identify better which of the parts of the match would be the real content to add as metadata.

PS.: This in fact was already implemented 7 months ago in PR #467, commit 91a8ac6. But it is a more generic implementation that can be used by other enhancements or custom user profiles, it is good to register as an new Issue (even to avoid some repeated implementation while PR 467 is not approved). PR #467 closes this issue.

@lfcnassif
Copy link
Member

Do you mean PR #1727 closes this, right?

@patrickdalla
Copy link
Collaborator Author

patrickdalla commented Jan 26, 2024

Yes, 467 is the original issue that PR #1727 solves, thanks.

@patrickdalla
Copy link
Collaborator Author

patrickdalla commented Jan 26, 2024

Additionally, the implementation falls back to the old implementation in case there is no named group with key and value names, so it is backward compatible with the current config file.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants