Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

.fna files #223

Closed
hildebra opened this issue Dec 7, 2023 · 4 comments
Closed

.fna files #223

hildebra opened this issue Dec 7, 2023 · 4 comments

Comments

@hildebra
Copy link

hildebra commented Dec 7, 2023

Hey,
I came across the following input related problem:
"
terminate called after throwing an instance of 'sharg::validation_error'
what(): Validation failed for option -d/--database: Expected one of the following valid extensions: [fa, fq, fasta, fastq, fa.gz, fq.gz, fasta.gz, fastq.gz]! Got fna instead!
MG.sh: line 17: 17139 Aborted lambda3 mkindexn -t 12 -d TIGR00539.fna
"

While I realize that normally this could be solved with a "mv", I am working with an array of reference databases shared for many users in an HPC environment. Would there be an easy way to override the ".fa" requirement?
Thanks,
Falk

@SGSSGene
Copy link
Collaborator

SGSSGene commented Dec 8, 2023

Hi Falk

The list of extension is hardcoded and there is no way to override it from the outside. ( std::vector<std::string> extensions{"fa", "fq", "fasta", "fastq"};). But you could edit the code and recompile by adding "fna".

See:

std::vector<std::string> extensions{"fa", "fq", "fasta", "fastq"};

and
std::vector<std::string> extensions{"fa", "fq", "fasta", "fastq"};

Other Idea: Instead of running 'mv' you could also use ln -s to create a sym link with fa extension. (But this might also not be an option for your HPC environment).

@hildebra
Copy link
Author

hildebra commented Dec 8, 2023

Thanks Simon,
I followed the ln -s route, but just a bit of a shame to have these hard limitations.
Thanks in any case for lambda3, really love the speed!
cheers,
Falk

@sarahet
Copy link
Member

sarahet commented Dec 13, 2023

Hi Falk,

Great to hear that you are happy with the new version of lambda. We will think about adding fna as a valid file extension in our next release of lambda3. We will let you know if it becomes available in the nearer future.

Sara

@sarahet
Copy link
Member

sarahet commented Dec 15, 2023

This has been addressed by #224 so you should be able to run lambda3 with fna file extension with the latest version of the lambda3 branch.

@sarahet sarahet closed this as completed Dec 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants