Skip to content
This repository has been archived by the owner on Jun 13, 2023. It is now read-only.

Merge in Kinesis implementation? #172

Open
colindean opened this issue May 10, 2018 · 3 comments
Open

Merge in Kinesis implementation? #172

colindean opened this issue May 10, 2018 · 3 comments

Comments

@colindean
Copy link
Contributor

https://github.com/bizreach/aws-kinesis-scala provides "jp.co.bizreach" %% "aws-kinesis-scala" and seems to have a very similar implementation style.

Maybe it could be or serve as the basis of implementing Kinesis support?

@seratch
Copy link
Owner

seratch commented May 15, 2018

It may be fine. What do you think? @takezoe

@takezoe
Copy link
Collaborator

takezoe commented May 15, 2018

aws-kinesis-scala consists the core module and the spark support module. I think the core module can be merged with AWScala basically, but it contains not only Scala wrapper of AWS-SDK but some additional features like automatic retry fashion. I'm not sure these features should be merged.

@seratch
Copy link
Owner

seratch commented May 18, 2018

Thank you for your detailed explanation. I prefer a simple wrapper of Java SDK.

Anyway, if somebody makes a pull request to merge a Kinesis module, I am willing to merge it regardless of whether it's based on aws-kinesis-scala or not.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants