Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggest remove the Extensions #61

Closed
wjqdst opened this issue Sep 19, 2024 · 8 comments · Fixed by #62
Closed

Suggest remove the Extensions #61

wjqdst opened this issue Sep 19, 2024 · 8 comments · Fixed by #62
Assignees
Labels
enhancement New feature or request

Comments

@wjqdst
Copy link

wjqdst commented Sep 19, 2024

WXWorkCapture_17267126618091 WXWorkCapture_17267126522149 WXWorkCapture_17267126146476 Hi, Because now in the TaskDefinition have 2 EquatableDictionary parameter, 1 is Extensions another is Metadata, but if we use odata it will casue error, and I see in the document we just have Metadata do not have Extensions, so I suggest to remove the Extensions parameter. Thanks.
@cdavernas cdavernas self-assigned this Sep 19, 2024
@cdavernas cdavernas added the enhancement New feature or request label Sep 19, 2024
@evil116
Copy link

evil116 commented Sep 20, 2024

when will the issue be resolved? @cdavernas

@cdavernas
Copy link
Member

cdavernas commented Sep 20, 2024

@evil116 Not before next week as I'm in PTO. If that's a problem, you are welcome to open a PR 😉

On a side note, @wjqdst @evil116 please be so kind to star the project to show your support!

@wjqdst
Copy link
Author

wjqdst commented Sep 20, 2024

@cdavernas noted with thanks, when you work next week, please let us know whether your team will fix this and when will have a new release for this. 😉

@wjqdst
Copy link
Author

wjqdst commented Sep 25, 2024

@cdavernas may I know this progress

@cdavernas
Copy link
Member

Still on PTO. As said, I'll try to solve it this week 😉 I'll keep you posted.

In the meanwhile, please do drop a star 🙏

@wjqdst
Copy link
Author

wjqdst commented Sep 25, 2024

noted, already drop.

@wjqdst
Copy link
Author

wjqdst commented Oct 1, 2024

@cdavernas may I know the progress again

@cdavernas
Copy link
Member

Merging in progress.

On a side note, and even though the extensions property was not required anymore, the metadata one should NOT be considered as an ODATA extension property: unlike extensions, it should be queryable just like any other top level properties.
To do so, you'd need to register EquatableDictionary<string, object> as a new complex type, or using a surrogate list type (ex: KvpList)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

3 participants