fix bindgen for BoringSSL on Windows #2089
Conversation
openssl-sys/build/run_bindgen.rs
Outdated
| .arg("--allowlist-file=.*[/\\\\]openssl/[^/]+\\.h") | ||
| .arg("--no-recursive-allowlist") |
openssl/src/x509/mod.rs
Outdated
| @@ -761,7 +761,7 @@ impl X509 { | |||
| ffi::PEM_read_bio_X509(bio.as_ptr(), ptr::null_mut(), None, ptr::null_mut()); | |||
| if r.is_null() { | |||
| let err = ffi::ERR_peek_last_error(); | |||
| if ffi::ERR_GET_LIB(err) as X509LenTy == ffi::ERR_LIB_PEM | |||
| if ffi::ERR_GET_LIB(err) as X509LenTy == ffi::ERR_LIB_PEM.try_into().unwrap() | |||
There was a problem hiding this comment.
I had a build error and cargo suggested me to make that change, it had a mismatch between i32 and u32. I don't know what caused that, maybe the boringssl version? I built boringssl from commit 5d58c559ace6a24ea6613e412b26bd4c50668ab3.
There was a problem hiding this comment.
It's not needed for either the version we're using in CI, nor for boringssl HEAD as far as I can tell, so it shouldn't be part of this PR
There was a problem hiding this comment.
I removed that and now got the same error
error[E0308]: mismatched types
--> openssl\src\x509\mod.rs:764:62
|
764 | if ffi::ERR_GET_LIB(err) as X509LenTy == ffi::ERR_LIB_PEM
| ---------------------------------- ^^^^^^^^^^^^^^^^ expected `u32`, found `i32`
| |
| expected because this is `u32`
|
help: you can convert an `i32` to a `u32` and panic if the converted value doesn't fit
|
764 | if ffi::ERR_GET_LIB(err) as X509LenTy == ffi::ERR_LIB_PEM.try_into().unwrap()
| ++++++++++++++++++++
That BoringSSL version is used by Python's cryptography 0.42
|
If this relies on a new version of bindgen, you'll need to change |
|
Looks like the linux build of boringssl now fails, probably that |
|
Some debugging will be required. Testing locally, it seems to work without |
- remove the -include flag (works for bindgen 0.68+) - fix allowlist-file regex to match Windows' path backslash
|
Yes it's the -include flag, I guess the CI is using old version of bindgen? |
also make path seperator windows friendly fixes sfackler#2087, sfackler#2086 closes sfackler#2089
also make path seperator windows friendly fixes sfackler#2087 fixes sfackler#2086 closes sfackler#2089
-includeflag (works for bindgen 0.68+) (fixes BoringSSL: -include argument is not supported by MSVC's cl.exe #2087)