update bindgen and no longer rely on -include
#2108
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alex
force-pushed
the
bindgen-boringssl
branch
from
830513e to
863acf3
Compare
also make path seperator windows friendly fixes sfackler#2087 fixes sfackler#2086 closes sfackler#2089
alex
force-pushed
the
bindgen-boringssl
branch
from
863acf3 to
46c5150
Compare
sfackler
reviewed
Nov 27, 2023
| @@ -119,14 +125,19 @@ pub fn run_boringssl(include_dirs: &[PathBuf]) { | |||
| .enable_function_attribute_detection() | |||
| .default_macro_constant_type(MacroTypeVariation::Signed) | |||
| .rustified_enum("point_conversion_form_t") | |||
| .allowlist_file(".*/openssl/[^/]+\\.h") | |||
| .allowlist_file(".*[/\\\\]openssl/[^/]+\\.h") | |||
There was a problem hiding this comment.
Don't the trailing separators need to be adjusted too?
There was a problem hiding this comment.
Great question. This part I just cargo culted from #2089
There was a problem hiding this comment.
No, I think the trailling separator comes directly from the include directive of the boringssl headers like #include <openssl/cipher.h>. The windows path will be like \path\to\boringssl\src\include\openssl/cipher.h.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
also make path seperator windows friendly
fixes #2087
fixes #2086
closes #2089