Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minimum and Array-like Actions #28

Closed
beelerchris opened this issue Sep 2, 2020 · 2 comments
Closed

Minimum and Array-like Actions #28

beelerchris opened this issue Sep 2, 2020 · 2 comments

Comments

@beelerchris
Copy link

The current algorithm assumes env.action_space.low = -env.action_space.high and env.action_space.high[0] = env.action_space.high[i] for all i, which is not the case for all environments.

@beelerchris beelerchris changed the title Minimum Actions Minimum and Array-like Actions Sep 2, 2020
@beelerchris
Copy link
Author

Please see the latest Pull request (#29) for changes I have made to correct this.

@sfujim
Copy link
Owner

sfujim commented Oct 12, 2020

Thank you for your effort! I'm mainly using this repo as a reference implementation for those who want to reproduce the paper on benchmark environments, which use symmetry in the action space. This is an additional level of detail for more specific use-cases, so I'd prefer to leave it as is.

@sfujim sfujim closed this as completed Oct 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants