Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support a serialization_configuration option for native_image #466

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Support a serialization_configuration option for native_image #466

wants to merge 1 commit into from

Conversation

chrismgrayftsinc
Copy link

Fixes #465

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Sep 17, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@sgammon sgammon self-assigned this Sep 19, 2024
@sgammon sgammon added the feature Mainline feature work label Sep 19, 2024
@sgammon sgammon added this to the 1.0.0 milestone Sep 19, 2024
sgammon
sgammon approved these changes Sep 19, 2024
View reviewed changes
Copy link
Owner

@sgammon sgammon left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@chrismgrayftsinc Looks clean, thank you very much for contributing 😄

I have authorized CI to run. To fix the DCO and Commitlint checks:

git commit --amend --sign

And edit your commit to follow the convention:

feat: add `serialization_configuration` option for `native_image`

You can use whatever commit message you want. As long as it has the feat prefix, it'll pass the check.

@sgammon sgammon added the native-image Features and issues relating to the Native Image tool label Sep 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sgammon sgammon sgammon approved these changes

Assignees

@sgammon sgammon

Labels
feature Mainline feature work native-image Features and issues relating to the Native Image tool
Projects
GraalVM Rules for Bazel
Status: In Progress
Milestone
1.0.0
Development

Successfully merging this pull request may close these issues.

Support serialization configuration
2 participants
@chrismgrayftsinc @sgammon