Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

_cat() does not preserve shapes #86

Open
xdevries opened this issue Nov 24, 2021 · 0 comments
Open

_cat() does not preserve shapes #86

xdevries opened this issue Nov 24, 2021 · 0 comments

Comments

@xdevries
Copy link

xdevries commented Nov 24, 2021

The _cat() methods (subplots.jl l103) does not preserve the shapes defined on the sub_layouts, I wrote a small fix. Perhaps we can make a PR out of this? I don't know how to make a fix branch.

function handle_shapes!(big_layout, sub_layout, ix::Int)
    if !isempty(sub_layout[:shapes])
        if !haskey(big_layout,:shapes)
            big_layout[:shapes] = Shape[]
        end
        for shape in sub_layout[:shapes]
            shape[:xref] = "x$ix"
            shape[:yref] = "y$ix"
            push!(big_layout[:shapes],shape)
        end
    end
end
@xdevries xdevries changed the title _cat() does not preserver shapes _cat() does not preserve shapes Nov 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant