You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I had two tags "harassment" and "abuse" that I wanted to consolidate. (I apologize for this example, I sometimes teach very depressing stuff.) I renamed "harassment" to "abuse" via the tag-rename tool (which I love, thank you for that). Any link that was tagged with both terms now has two "abuse" tags, as seen in the screenshot below.
This doesn't seem to break anything -- tag-searching "abuse" still works as expected, I checked -- but it clutters the display a bit. Possible to have the tag-replace process check each link to see if the new tag is already there?
The text was updated successfully, but these errors were encountered:
But I only updated the addTag() function, not renameTag(). I've submitted a pull request to make renameTag() effectively merge the old and new tags if both exist on a bookmark.
I had to rewrite most of ManageTagControllerTest. It heavily used stubs and I don't think it was actually testing the renaming of the tags. The new version fails (as expected) if you run it against the current bookmark code.
I had two tags "harassment" and "abuse" that I wanted to consolidate. (I apologize for this example, I sometimes teach very depressing stuff.) I renamed "harassment" to "abuse" via the tag-rename tool (which I love, thank you for that). Any link that was tagged with both terms now has two "abuse" tags, as seen in the screenshot below.
This doesn't seem to break anything -- tag-searching "abuse" still works as expected, I checked -- but it clutters the display a bit. Possible to have the tag-replace process check each link to see if the new tag is already there?
The text was updated successfully, but these errors were encountered: