Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an option to show/hide RSS link #517

Closed
aurmil opened this issue Mar 16, 2016 · 5 comments
Closed

Add an option to show/hide RSS link #517

aurmil opened this issue Mar 16, 2016 · 5 comments
Labels
Milestone

Comments

@aurmil
Copy link

aurmil commented Mar 16, 2016

hello

I personnaly don't need the RSS feed so I would like to hide the RSS link in page.header.html
you could add an option as for SHOW_ATOM

thanks
regards

@ArthurHoaro
Copy link
Member

Hi. This behavior will probably change with template rewriting in v0.8:

  • ATOM feed button as default.
  • An option to display to display the RSS feed instead,

@ArthurHoaro ArthurHoaro added this to the 0.8.0 milestone Mar 16, 2016
@aurmil
Copy link
Author

aurmil commented Mar 16, 2016

OK thanks for answering

so, + an option to display no button ;)

@nodiscc
Copy link
Member

nodiscc commented Mar 16, 2016

Uh ATOMS/RSS feeds are a core fetaure of Shaarli and I don't think there should be an option to hide them. This looks more like a job for a trimmed-down template. Else we would end up adding a hide/show option for every single button/item.

@aurmil
Copy link
Author

aurmil commented Mar 17, 2016

OK, I personnaly don't need RSS or ATOM feeds (links are just for my own use) but I understand your point

@nodiscc
Copy link
Member

nodiscc commented Mar 17, 2016

Thank you for understanding; note that it might be a good idea to make each button easily hideable via CSS when rewriting the template (#266) (eg. <div id=rssbutton> in template, let users add #rssbutton { display: none } to custom CSS)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants