Stage block 2D choice

[johanneswieland]

I know the stage block code is still experimental, but I wanted to flag this issue if it has not come up yet.

The function inputs in line 115 of law_of_motion.py do not correspond to the required inputs for forward_policy_shock_2d. Executing this line throws the error 'ShockedPolicyLottery2D' object has no attribute 'i' since the object only has attributes that look like i1 and i2.

sequence-jacobian/src/sequence_jacobian/blocks/support/law_of_motion.py

Lines 112 to 117 in ac77f11

	class ShockedPolicyLottery2D(PolicyLottery2D):
	def __matmul__(self, X):
	if self.forward:
	return het_compiled.forward_policy_shock_2d(X.reshape(self.flatshape), self.i, self.pi).reshape(self.shape)
	else:
	raise NotImplementedError

[bbardoczy]

Thanks for pointing this out, Johannes. We're planning to introduce some refinements of stage blocks soon, as well as addressing some of the issues raised by the community.

[johanneswieland]

Great, looking forward to it!

…

On Jan 20, 2023, at 5:51 AM, Bence ***@***.***> wrote: Thanks for pointing this out, Johannes. We're planning to introduce some refinements of stage blocks soon, as well as addressing some of the issues raised by the community. — Reply to this email directly, view it on GitHub <#14 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AOHSKVPIBJN6PMJT6VADGYTWTKJ43ANCNFSM6AAAAAAUAW3KMA>. You are receiving this because you authored the thread.