Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature: Prevent logging sensitive data in verbose mode #97

Closed
ahangarha opened this issue Nov 3, 2023 · 2 comments · Fixed by #115
Closed

Feature: Prevent logging sensitive data in verbose mode #97

ahangarha opened this issue Nov 3, 2023 · 2 comments · Fixed by #115
Labels
enhancement New feature or request

Comments

@ahangarha
Copy link
Contributor

ahangarha commented Nov 3, 2023 •
edited
Loading

From #91

Don't echo any token (applies to promote-app-from-upstream)
@ahangarha ahangarha added the enhancement New feature or request label Nov 3, 2023
@ahangarha
Copy link
Contributor Author

What type of messages do we want to show in the verbose mode?
Would we have verbose warnings, too?

@ahangarha ahangarha mentioned this issue Nov 22, 2023
Merged
@ahangarha ahangarha changed the title Feature: Verbose mode Feature: Prevent logging sensitive data in verbose mode Nov 22, 2023
@justin808
Copy link
Member

@ahangarha please don't propose enhancements and then just start them without approval. 🤯

@ahangarha ahangarha reopened this Nov 25, 2023
@ahangarha ahangarha mentioned this issue Nov 25, 2023
Open
17 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add feature to hide sensitive data in logs shakacode/control-plane-flow
2 participants
@justin808 @ahangarha