From 271bfc39fd7b27b6846e988c3e54bff1fb2a3851 Mon Sep 17 00:00:00 2001
From: Shankari <shankari@eecs.berkeley.edu>
Date: Sun, 25 Aug 2024 17:00:39 -0700
Subject: [PATCH] =?UTF-8?q?=F0=9F=9B=82=20Manifest-related=20changes=20to?=
 =?UTF-8?q?=20support=20the=20foreground=20service=20in=20android=2014?=
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

This addresses a couple of the issues in
https://github.com/e-mission/e-mission-docs/issues/1079#issuecomment-2309049358

❌ If apps that target Android 14 use a foreground service, they must declare a
specific permission, based on the foreground service type, that Android 14
introduces.

**FIXed by**

✔️  Added `FOREGROUND_SERVICE_HEALTH` and `FOREGROUND_SERVICE_LOCATION` permissions

❌ ACTIVITY_RECOGNITION permission seems to imply health as part of the foreground service as well

**FIXed by**

✔️  Changed the type to `android:foregroundServiceType="location|health"`

Bumped up the plugin version as well
---
 plugin.xml | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/plugin.xml b/plugin.xml
index 3ead8f0..c396714 100644
--- a/plugin.xml
+++ b/plugin.xml
@@ -1,7 +1,7 @@
 <?xml version="1.0" encoding="utf-8"?>
 <plugin xmlns="http://www.phonegap.com/ns/plugins/1.0"
         id="cordova-plugin-em-datacollection"
-        version="1.8.8">
+        version="1.8.9">
 
   <name>DataCollection</name>
   <description>Background data collection FTW! This is the part that I really
@@ -54,6 +54,8 @@
         <uses-permission android:name="com.google.android.gms.permission.ACTIVITY_RECOGNITION"/>
         <uses-permission android:name="android.permission.ACTIVITY_RECOGNITION"/>
         <uses-permission android:name="android.permission.FOREGROUND_SERVICE" />
+        <uses-permission android:name="android.permission.FOREGROUND_SERVICE_HEALTH" />
+        <uses-permission android:name="android.permission.FOREGROUND_SERVICE_LOCATION" />
         <!-- COARSE_LOCATION obfuscates the location to a city block, change to FINE_LOCATION for accuracy -->
         <uses-permission android:name="android.permission.ACCESS_FINE_LOCATION"/>
         <uses-permission android:name="android.permission.ACCESS_BACKGROUND_LOCATION"/>
@@ -109,7 +111,7 @@
         <service
             android:name="edu.berkeley.eecs.emission.cordova.tracker.location.TripDiaryStateMachineForegroundService"
             android:enabled="true"
-            android:foregroundServiceType="location"
+            android:foregroundServiceType="location|health"
             android:exported="false">
         </service>
         <service