Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WalletConnect To DApps: "Invalid order signature" when attempting to list an NFT for auction #5384

Closed
0xMillz opened this issue Oct 2, 2023 · 4 comments · Fixed by #5553
Closed
Assignees
Labels
nice to have mayyyybe one day

Comments

@0xMillz
Copy link
Contributor

0xMillz commented Oct 2, 2023

Overview

I've been trying to list a Polygon NFT that I hold on my KeepKey for sale on the OpenSea dApp (auction-type) via the Connect to Dapp feature in web. I am able to approve it and sign all the data messages on my KeepKey but when the final response is sent back to the OpenSea dApp, the dApp briefly displays a toast message that says "Invalid order signature" and the browser dev logs for OpenSea throw a graphql error, somethings about useHandleBlockchainActionsCreateOrderMutation (see final screenshot):
Screenshot 2023-10-02 at 09 00 23
Screenshot 2023-10-02 at 09 02 28
Screenshot 2023-10-02 at 09 02 41
Screenshot 2023-10-02 at 09 05 40

References and additional details

I'm guessing it could be a fix like this one but I really haven't dug into the code yet

Acceptance Criteria

You can sucessfully list for sale a Polygon NFT on the OpenSea dApp

Need By Date

No response

Screenshots/Mockups

No response

Estimated effort

4 - 8 hours, optimistically

@0xMillz
Copy link
Contributor Author

0xMillz commented Oct 2, 2023

Self-assigning this issue to myself. I don't have repo privileges so can't do it officially

@twblack88 twblack88 added the nice to have mayyyybe one day label Oct 2, 2023
@0xMillz
Copy link
Contributor Author

0xMillz commented Oct 10, 2023

Closing this issue as "won't do", as it appears to be related to KeepKey only and out of the domain of web. Using @metamask/eth-sig-util's recoverTypedSignature_v4, I was able to verify that the recovered address from the signatures produced from wallets like ShapeShift Native for eth_signTypedData_v4 messages are accurate, while for KeepKey they are not. Ref: https://github.com/MetaMask/eth-sig-util/blob/cf4352793a78727df8b0585190b4d39d5c166ba4/src/sign-typed-data.ts#L853C39-L853C39

@0xMillz 0xMillz closed this as not planned Won't fix, can't repro, duplicate, stale Oct 10, 2023
@0xMillz 0xMillz reopened this Oct 18, 2023
@0xMillz
Copy link
Contributor Author

0xMillz commented Oct 18, 2023

Reopened because I came up with a solution. A PR to hdwallet is incoming and then a PR to web will follow with an hdwallet version bump

@0xMillz
Copy link
Contributor Author

0xMillz commented Oct 19, 2023

This is the PR in hdwallet that will fix this issue: shapeshift/hdwallet#649
Once web bumps to the version of hdwallet containing the above change, this issue should be resolved!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
nice to have mayyyybe one day
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants